Fix issue1032 error on sparqlstore update · Pull Request #1623 · RDFLib/rdflib (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a PR to add tests to your banch (https://github.com/gjhiggins/rdflib/pull/1)

Change looks good, TypeError may not be the best exception to raise for this situation and I think NotImplementedError may be better, but since all other modification methods raise TypeError it makes most sense to do the same for SPARQLStore.update. We can look at changing all exceptions later versions (noted here #1628). As a side note on this, TypeError is handled differently from other exceptions in many places: see #1524 for example.