fix sonarcloud-reported bug in xmlwriter, add test · Pull Request #1951 · RDFLib/rdflib (original) (raw)

Summary of changes

sonarcloud detected a bug: “Remove 1 unexpected arguments; 'join' expects 1 positional arguments.” in xmlwriter:

return ":".join(pre, uri[len(ns) :])

Added containing brackets apparently omitted by original author.

return ":".join([pre, uri[len(ns) :]])

Added test for surety, took the opportunity of adding two tests to take coverage of xmlwriter to 100%.

Checklist

• Checked that there aren't other open pull requests for the same change.
• Added tests for any changes that have a runtime impact.
• Checked that all tests and type checking passes.
• Considered granting push permissions to the PR branch,
  so maintainers can fix minor issues and keep your PR up to date.