Add more tests for graph_diff by aucampia · Pull Request #1983 · RDFLib/rdflib (original) (raw)

Summary of changes

This is to confirm that graph_diff does not work with quads.

Other changes:

• Added support to GraphHelper for collapsing BNodes to a specifc IRI
  when coverting to triple sets, this is in addition to the current
  functionality for ignoring bnodes. This makes it possible to more
  accurately compare Graphs that contain blank nodes.
• Added assert_cgraph_isomorphic to GraphHelper.
  This method adds some rudementary support for checking if conjunctive
  graphs are isomorphic, it will ignore named graphs that have blank
  nodes as name.

Checklist

• Checked that there aren't other open pull requests for
  the same change.
• Checked that all tests and type checking passes.
• Considered granting push permissions to the PR branch,
  so maintainers can fix minor issues and keep your PR up to date.

Coverage increased (+0.01%) to 88.525% when pulling a51580f on aucampia:iwana-20220604T2208-quad_diff into e677274 on RDFLib:master.

This is to confirm that graph_diff does not work with quads.

Other changes:

• Added support to GraphHelper for collapsing BNodes to a specifc IRI when coverting to triple sets, this is in addition to the current functionality for ignoring bnodes. This makes it possible to more accurately compare Graphs that contain blank nodes.
• Added assert_cgraph_isomorphic to GraphHelper. This method adds some rudementary support for checking if conjunctive graphs are isomorphic, it will ignore name graphs that have blank nodes as name.

aucampia marked this pull request as ready for review

June 5, 2022 11:50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very necessary

ghost removed the review wanted

This indicates that the PR is ready for review

label

Jun 8, 2022

aucampia deleted the iwana-20220604T2208-quad_diff branch

June 23, 2022 19:42