Fallback to old Store.bind
signature on TypeError
by aucampia · Pull Request #2018 · RDFLib/rdflib (original) (raw)
Summary of changes
If Store.bind
raises a TypeError
, and the string conversion of this
TypeError contains override
, then log a warning and call Store.bind
without an override.
This is done so that stores that do not accept override
onStore.bind
still work, but at the cost of still having the bug that
was fixed by introducing the override
parameter.
Also added a private flag which can be used to disable the fix entirely
and never use override
when calling Store.bind
.
Checklist
- Checked that there aren't other open pull requests for
the same change. - Added tests for any changes that have a runtime impact.
- Checked that all tests and type checking passes.
- Considered granting push permissions to the PR branch,
so maintainers can fix minor issues and keep your PR up to date.