build: Taskfile improvements by aucampia · Pull Request #2032 · RDFLib/rdflib (original) (raw)
Summary of changes
- Added individual tasks for black, isort and mypy to make it easier to
run these directly. - Change flag variables to be JSON based so that they can be disabled
with "false", this makes it easier to work with tooling that does not
distinguish between empty and unset environment variables. - Add a
venv:runtarget to make it easier to run things inside the
venv, e.g.task venv:run -- pip install lxml. - Change pytest invocation to use the pytest script instead of using
python -m pytestas the latter does some things which are not
desirable.
Checklist
- Checked that there aren't other open pull requests for
the same change. - Checked that all tests and type checking passes.
- Considered granting push permissions to the PR branch,
so maintainers can fix minor issues and keep your PR up to date.
Coverage remained the same at 90.446% when pulling 6553986 on aucampia:iwana-20220717T1633-taskfile into 0d413fd on RDFLib:master.
I'm going to update this to also change how pytest is invoked to address this comment: #1519 (comment)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- Added individual tasks for black, isort and mypy to make it easier to run these directly.
- Change flag variables to be JSON based so that they can be disabled with "false", this makes it easier to work with tooling that does not distinguish between empty and unset environment variables.
- Add a
venv:runtarget to make it easier to run things inside the venv, e.g.task venv:run -- pip install lxml. - Change pytest invocation to use the pytest script instead of using
python -m pytestas the latter does some things which are not desirable.