Fix passing ConjunctiveGraph as namespace_manager by mielvds · Pull Request #2073 · RDFLib/rdflib (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mielvds thanks for the PR. While I think it is pretty safe and uncontroversial it would still be good to have tests for this.

Also, we are trying to reduce the effort it takes to make a release, and one part of this is to keep the changelog up to date always:

So it would be good if you could add tests and update the changelog, but I will try find some time this weekend to add tests and update the change on your PR branch if it is not done yet, as this is rather important to fix.