feat: add parser type hints by aucampia · Pull Request #2232 · RDFLib/rdflib (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Summary of changes

Add type hints to:

rdflib/parser.py
rdflib/plugins/parser/*.py
some JSON-LD utils
rdflib/exceptions.py.

This is mainly because the work I'm doing to fix
#1844 is touching some of this parser stuff and the type hints are useful to avoid mistakes.

No runtime changes are included in this PR.

Checklist

Checked that there aren't other open pull requests for
the same change.
Checked that all tests and type checking passes.
Considered granting push permissions to the PR branch,
so maintainers can fix minor issues and keep your PR up to date.

A compact diff with all non-runtime content (e.g. comments, type-hints) stripped out can be found here: https://gist.github.com/aucampia/91e1bfb27351ebd63c3285d052a34d7e#file-compact-diff

Generated with:

20230220T204956 iwana@teekai.zoic.eu.org:~/sw/d/github.com/iafork/rdflib.reviews $ git log -1 commit db682801f0b2a3a05cbe8e9c33a93911e6103a04 (HEAD -> iwana-20230220T2005-add_parser_typing) Author: Iwan Aucamp aucampia@gmail.com Date: Mon Feb 20 19:36:30 2023 +0000

feat: add parser type hints

Add type hints to `rdflib/plugins/parser/*.py` and JSON-LD utils.

This is mainly because the work I'm doing to fix
<https://github.com/RDFLib/rdflib/issues/1844> is touching some of this
parser stuff and the type hints are useful to avoid mistakes.

20230220T204958 iwana@teekai.zoic.eu.org:~/sw/d/github.com/iafork/rdflib.reviews $ git status On branch iwana-20230220T2005-add_parser_typing Your branch and 'origin/iwana-20230220T2005-add_parser_typing' have diverged, and have 1 and 1 different commits each, respectively. (use "git pull" to merge the remote branch into yours)

nothing to commit, working tree clean 20230220T205000 iwana@teekai.zoic.eu.org:~/sw/d/github.com/iafork/rdflib.reviews $ PYLOGGING_LEVEL=INFO task run -- git difftool -y -x $(readlink -f devtools/diffrtpy.py) upstream/main > /var/tmp/compact.diff task: [venv:run] poetry run git difftool -y -x /home/iwana/sw/d/github.com/iafork/rdflib.reviews/devtools/diffrtpy.py upstream/main

aucampia marked this pull request as ready for review