Avoid class reference to imported function by dbs · Pull Request #578 · RDFLib/rdflib (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

dbs

We import the urljoin() function directly to support both Py2 and Py3, so the
reference to urlparse.urljoin() raises an exception. Don't do that!

Fixes 574.

Signed-off-by: Dan Scott dan@coffeecode.net

@dbs

We import the urljoin() function directly to support both Py2 and Py3, so the reference to urlparse.urljoin() raises an exception. Don't do that!

Fixes 574.

Signed-off-by: Dan Scott dan@coffeecode.net

joernhees added a commit that referenced this pull request

Jan 25, 2016

@joernhees

Avoid class reference to imported function

@joernhees

thanks, we'll see what remains after the pyMicrodata cleanup though ;)

@dbs dbs mentioned this pull request

Feb 16, 2016

@joernhees

@joernhees

@iherman

@joernhees if you mean whether my local copy is in sync with the current master (including your change in adding the csvw to the initial context, thanks for this!) then yes, I am in sync. I plan to update the initial context at the end of February, when some more Recommendations will be added to the mix.

This was referenced

Mar 16, 2017