make SPARQLConnector work with DBpedia by joernhees · Pull Request #941 · RDFLib/rdflib (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

joernhees

i think this was a leftover from #744

DBpedia seems to answer with application/sparql-results+xml; charset=UTF-8 header, which wasn't registered in plugins...

also unskips an old test on travis tha otherwise failed locally due to now unresolved SPARQLWrapper exception ref

@joernhees

also unskips an old test on travis tha otherwise failed locally due to now unresolved SPARQLWrapper exception ref

@gromgull

My gut feel would be to strip off the ; chatset=.. bit before looking for plugins.

Will we have one plugin for utf-8, one for utf-16?

But whatever, I don't care that deeply :D

@joernhees

close & reopen to trigger travis...

@joernhees

yupp, actually thought about that, but didn't find the right spot quickly... also question is: what if the encoding is different, how to handle that correctly?

I'll merge for now as a quick-fix is better than none, but feel free to cleanup

2 participants

@joernhees @gromgull