Eigen 3.4.0 by yixuan · Pull Request #102 · RcppCore/RcppEigen (original) (raw)

Hey -- good to hear from you. I am really torn. I like 'linear' -- at work we enforce it via 'squash merge': each PR is a squash.

I don't mind standard PR with (usually) just one departure:

I am less of a fan where it gets 'wild'

Because yours started so long ago we'd have a really long parallel history. But then again we a) have never squashed and b) it's nice if your work is reflected as is.

So kinda leaning towards normal 'noisy' merge. What do you think?

[ But most importantly: it does not really matter. Code quality matters, clean tests, good ci. This is mostly cosmetic. It matters really only a little bit. ]