3.x: Reenable XFlatMapTest.maybeSingle, add missing Single operators by akarnokd · Pull Request #6893 · ReactiveX/RxJava (original) (raw)

Reenable the XFlatMapTest.maybeSingle and make sure all flatMap variants behave the same when the flow is cancelled/disposed while the mapper function is executing, thus the returned inner source doesn't get subscribed to at all.

Resolves #6892

While adding the extra tests, I noticed two flatMap variant is missing from Single:

• A combiner of the original and inner success item: flatMap(Function<T, Single<U>>, BiFunction<T, U, R>)
• A notification-type mapper: flatMap(Function<T, Single<R>>, Function<Throwable, Single<R>>)

Lastly, the same combiner variant for Maybe received a marble diagram too:

Related #5806