Allow building of sqlite JSON1 extension when building internal sqlite library by richardhozak · Pull Request #288 · SRombauts/SQLiteCpp (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I added cmake option to enable json1 extension when building internal sqlite library.
I added the option under the SQLITECPP_INTERNAL_SQLITE if statement so it is clear that this option is only valid when building the internal sqlite library.

Coverage remained the same at 100.0% when pulling 0d2294e on zxey:feature-json1-extension into 9106e8d on SRombauts:master.

Hi @Zxey I wasn't aware of this extension, do you know since when it exists?

Anyway, I think it's a great feature 👍

The only small change I would propose is to actually set SQLITE_ENABLE_JSON1 publicly so the client code would be able to test for this feature.

This was referenced

May 29, 2023

See PR #428 for the new branch I just pushed:
I am going to remove option SQLITE_ENABLE_JSON1 since the JSON functions and operators are built into SQLite by default, as of SQLite version 3.38.0 (2022-02-22).

For us with SQLiteCpp it would be since Version 3.2.0 - 2022 September 18