Docker: Remove Hub GraphQL dependency from video recorder by VietND96 · Pull Request #2813 · SeleniumHQ/docker-selenium (original) (raw)

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

After the fix [java] Add "se" prefixed capabilities to session response (SeleniumHQ/selenium#14323) available from version 4.24+
All capabilities with prefix se: could be seen in Node /status session capabilities.
Video recorder to get file name via cap se:name, or se:videoName no need to extract from Hub GraphQL anymore.
Container video recorder also no need to pass ENV variable of Hub GraphQL anymore.

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the contributing document.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

PR Type

Enhancement

Description

Remove Hub GraphQL dependency from video recorder logic
- Use session capabilities from Node /status endpoint
- Eliminate need for Hub GraphQL ENV variable
Add new script to extract video recording info from capabilities
- Determine video file name and recording flag from session capabilities

Changes walkthrough 📝

Relevant files
Enhancement	video.shRefactor video recorder to use Node session capabilities Video/video.sh Refactored to fetch session info from Node /status endpoint, not GraphQL Added logic to extract video recording info from session capabilities Removed all Hub GraphQL endpoint and ENV variable usage Integrated new script for video file name and recording flag extraction +12/-13 video_nodeQuery.shAdd script to parse video recording info from capabilities Video/video_nodeQuery.sh New script to extract video recording flag and file name from session capabilities Determines file name based on se:name or se:videoName capabilities Normalizes and formats the video file name Outputs recording flag and file name for use by other scripts +49/-0

Relevant files

Enhancement

video.shRefactor video recorder to use Node session capabilities Video/video.sh Refactored to fetch session info from Node /status endpoint, not GraphQL Added logic to extract video recording info from session capabilities Removed all Hub GraphQL endpoint and ENV variable usage Integrated new script for video file name and recording flag extraction +12/-13 video_nodeQuery.shAdd script to parse video recording info from capabilities Video/video_nodeQuery.sh New script to extract video recording flag and file name from session capabilities Determines file name based on se:name or se:videoName capabilities Normalizes and formats the video file name Outputs recording flag and file name for use by other scripts +49/-0

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.