[java][grid]: Set test name to video file name in dynamic grid by VietND96 · Pull Request #13907 · SeleniumHQ/selenium (original) (raw)

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

[java][grid]: Set test name to video file name in dynamic grid

Motivation and Context

This is based on the support of Metadata in tests. When running test with dynamic grid, by adding metadata to your tests, the video file name will extract the value of capability se:name and then set to output the video file name.

For example, in Python binding:

from selenium.webdriver.chrome.options import Options as ChromeOptions from selenium import webdriver

options = ChromeOptions() options.set_capability('se:recordVideo', True) options.set_capability('se:screenResolution', '1920x1080') options.set_capability('se:name', 'test_visit_basic_auth_secured_page (ChromeTests)') driver = webdriver.Remote(options=options, command_executor="http://localhost:4444") driver.get("https://selenium.dev") driver.quit()

After test executed, under /assets you can see the video file name under /<sessionId>/test_visit_basic_auth_secured_page_ChromeTests.mp4

File name will be trimmed to 255 characters to avoid long file names. Moreover, space character will be replaced by _ and only characters alphabets, numbers, - (hyphen), _ (underscore) are retained in the file name.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

Type

enhancement

Description

• Refactored the handling of environment variables in DockerSessionFactory for better clarity and separation of concerns.
• Introduced functionality to set the video file name based on the se:name capability, enhancing traceability of test artifacts.
• Implemented sanitization and truncation for video file names to ensure compatibility and prevent excessively long file names.
• Updated the JDK version in the IDE configuration to JDK 17, aligning with updated language features and support.

Changes walkthrough

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions