Fix path separator in NuGet push command for GitHub packages by Shane32 · Pull Request #637 · Shane32/QRCoder (original) (raw)

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Adjusts NuGet publish steps in two GitHub Actions workflows by removing explicit bash shells, letting them run under the default Windows shell, and changing the push path wildcard from out/* to out*.

Changes

Cohort / File(s)	Summary of changes
CI workflows: publish step shell/path tweak.github/workflows/wf-build-release-ci.yml, .github/workflows/wf-build-release.yml	Removed explicit bash shell; default Windows shell (pwsh) now used. Updated NuGet push path from out/* to out\* to match Windows-style wildcard escaping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Update CI workflows and project files for improved package management and versioning #632 — Also modifies CI workflow publish steps; closely related shell/path handling changes.
Update CI workflow for pushing to master #623 — Prior restructuring of CI pack/publish jobs in .github/workflows, directly connected to these adjustments.

Suggested reviewers

gfoidl ✨ Finishing touches 🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-ci-2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75720a5 and 3833005.

📒 Files selected for processing (2)

.github/workflows/wf-build-release-ci.yml (1 hunks)
.github/workflows/wf-build-release.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share