Add support for count argument to ListLeftPop, ListLeftPopAsync, ListRightPop, and ListRightPopAsync by jjfmarket · Pull Request #1850 · StackExchange/StackExchange.Redis (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Add support for count argument to ListLeftPop, ListLeftPopAsync, ListRightPop, and ListRightPopAsync

Optional Count argument was added in Redis 6.2

…RightPop, and ListRightPopAsync

Optional Count argument was added in Redis 6.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Can you add something to the release notes md, too?

Also: thanks for not.falling into the trap of adding an optional arg to the existing method. You'd be surprised how often we need to explain about that.

…LeftPop, ListLeftPopAsync, ListRightPop, and ListRightPopAsync"

Added a note to the release notes 👍🏻

@jjfmarket I've been on a work break here - sorry for the slow response but your effort is very much appreciated <3