Added CommandMap check before requesting cluster nodes by tylerohlsen · Pull Request #2014 · StackExchange/StackExchange.Redis (original) (raw)
Interesting that this failed with Envoy proxy. It looks like Envoy does actually support RedisCommand.CLUSTER even though their documentation doesn't list it. So should I remove that from the exclusions here?
| /// |
|---|
| /// The commands available to envoyproxy. |
| /// |
| public static CommandMap Envoyproxy { get; } = CreateImpl(null, exclusions: new HashSet<RedisCommand> |
| { |
| // see https://www.envoyproxy.io/docs/envoy/latest/intro/arch\_overview/other\_protocols/redis.html?highlight=redis |
| RedisCommand.KEYS, RedisCommand.MIGRATE, RedisCommand.MOVE, RedisCommand.OBJECT, RedisCommand.RANDOMKEY, |
| RedisCommand.RENAME, RedisCommand.RENAMENX, RedisCommand.SORT, RedisCommand.SCAN, |
| RedisCommand.BITOP, RedisCommand.MSETNX, |
| RedisCommand.BLPOP, RedisCommand.BRPOP, RedisCommand.BRPOPLPUSH, // yeah, me neither! |
| RedisCommand.PSUBSCRIBE, RedisCommand.PUBLISH, RedisCommand.PUNSUBSCRIBE, RedisCommand.SUBSCRIBE, RedisCommand.UNSUBSCRIBE, |
| RedisCommand.DISCARD, RedisCommand.EXEC, RedisCommand.MULTI, RedisCommand.UNWATCH, RedisCommand.WATCH, |
| RedisCommand.SCRIPT, |
| RedisCommand.ECHO, RedisCommand.QUIT, RedisCommand.SELECT, |
| RedisCommand.BGREWRITEAOF, RedisCommand.BGSAVE, RedisCommand.CLIENT, RedisCommand.CLUSTER, RedisCommand.CONFIG, RedisCommand.DBSIZE, |
| RedisCommand.DEBUG, RedisCommand.FLUSHALL, RedisCommand.FLUSHDB, RedisCommand.INFO, RedisCommand.LASTSAVE, RedisCommand.MONITOR, RedisCommand.REPLICAOF, |
| RedisCommand.SAVE, RedisCommand.SHUTDOWN, RedisCommand.SLAVEOF, RedisCommand.SLOWLOG, RedisCommand.SYNC, RedisCommand.TIME, |
| // supported by envoy but not enabled by stack exchange |
| // RedisCommand.BITFIELD, |
| // |
| // RedisCommand.GEORADIUS_RO, |
| // RedisCommand.GEORADIUSBYMEMBER_RO, |
| }); |