ZMPOP and LMPOP by slorello89 · Pull Request #2094 · StackExchange/StackExchange.Redis (original) (raw)

@NickCraver - apologies for the formatting changes in RedisDatabase, Rider apparently had some opinions and I didn't catch it when I was pushing it, I'll clean it up

• RE naming, yeah names are tough to come up for these, I was considering using RedisList and RedisSortedSet because the precedent was already there for RedisStream which does something similar, but I didn't want to reserve those class names, hence the use of ListSpan and SortedSetSpan as they are contiguous regions of lists/sorted sets (the name was an intentional homage to that). Maybe SubList and SortedSubSet?
• I can work up some derived Null value
• RE Cluster - I had similar questions, given the questions RE streams that have come up in the last couple days, I can spin up a cluster and check, but I'd guess that it will either throw up if all the keys aren't on the node, or if it comes across a key as it's scanning through this list of keys, either way, it shouldn't be operating across shards. There doesn't appear to be a message that takes an array of keys and an array of values, so maybe we need a new message CommandValueKeysValuesMessage? I'll work up some Cluster test-cases for this as well