Repeat: Docs: Love! Linking, fixes, code formatting, etc. by NickCraver · Pull Request #2109 · StackExchange/StackExchange.Redis (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@NickCraver

Repeat of #2100, for after #2071 goes in.

This does a few things globally to the interfaces:

In general: docs only change - I think we should merge this as-is to help PRs coming in, then I'll continue to iterate on docs.

@NickCraver

I missed an overload case being an idiot - adding the missing source break for the case in #2071.

...also fixing KeyTouch ordering while in here.

Note that adding CommandFlags back optional seems like a quick fix and I did try that route, but in a full test suite here it became apparent that created other ambiguous overload cases, so went this route.

@NickCraver

This does a few things globally to the interfaces:

In general: docs only change - I think we should merge this as-is to help PRs coming in, then I'll continue to iterate on docs.

@NickCraver

…2108)

Reverts #2100

This was aimed to be merged after #2098 landed, my fault. Reverting out for that to happen.

@NickCraver

@NickCraver

@NickCraver NickCraver changed the base branch from craver/fix-2071 to main

April 19, 2022 15:24

@NickCraver

@NickCraver NickCraver changed the titleRepeat: Docs: Love! Linking, fixes, code formatting, etc."" Repeat: Docs: Love! Linking, fixes, code formatting, etc.

Apr 19, 2022

@NickCraver

Approved in #2100, re-merging here.

@NickCraver NickCraver deleted the revert-2108-revert-2100-craver/docs-update-1 branch

April 19, 2022 15:56

2 participants

@NickCraver