Adds support for XPENDING IDLE parameter by david-brink-talogy · Pull Request #2822 · StackExchange/StackExchange.Redis (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a suggestion on the overloads? This Redis API can satisfy a number of use cases depending on the parameters passed. minIdleTimeInMs can be used with various combinations of consumerName, minId, and maxId. If new overloads do not have defaults, several overloads would likely be needed to satisfy all use cases which complicates the public API.

With this many arguments I'd generally lean toward an class like StreamPendingMessagesArgs, but that seems to run afoul of the existing design.

The PR as it currently exists seemed like a reasonable compromise between backwards compatibility and adhering to the design.