Implement GetServer(RedisKey, ...) by mgravell · Pull Request #2936 · StackExchange/StackExchange.Redis (original) (raw)

Main feedback: the RS0026/RS0027 suppression gives me pause here, since that's commonly a source of feedback especially with null calls. Potentially separately or on top the params object[] and ICollection<object> overloads I think maybe are something we should avoid given C# advances allowing terse calls to do the same thing now (generating the params overload effectively). If users can do Method(argA, argB, [param, param2, param3]) these days, IMO we should avoid the overload ambiguity and chance for user error...but maybe I'm missing a major case - thoughts?