Bundle the app for macOS by Yudi · Pull Request #1375 · Tyrrrz/DiscordChatExporter (original) (raw)

Conversation

Closes #1249

TODO:

• Docs (Gatekeeper)
• Icon
  • Use low resolution icon for now
• Create the .app on pack instead. Then users will be able to use CI builds more easily
  • Check if chmod change breaks Linux releases
• Test CLI
  • No changes required

This PR adds steps to the pack and deploy jobs.

pack:

• Set permissions for non-win releases
• Bundle the .app by arranging the files
  1. Create .app folder structure inside a staging/ directory

  DiscordChatExporter.app/  
    Contents/  
      Info.plist  
      MacOS/  
        [All publish files go here]  
      Resources/  
        AppIcon.icns  

  1. Move favicon.icns to staging/.app/Contents/Resources/AppIcon.icns
  2. Create Information Property List (Info.plist) inside the publish/ directory
  3. Move all files from publish to staging/.app/Contents/MacOS
  4. Move .app to publish folder

deploy:

• Moved "set permissions" to pack job
  • Then users are able to run CI builds

@Tyrrrz If you still have the original favicon files, would you mind sending them to me here or on Discord?
macOS icons should be 1024x1024 and favicon.png is only 256x256.

Yudi changed the titleBundle the app for MacOS Bundle the app for macOS

May 5, 2025

@Tyrrrz If you still have the original favicon files, would you mind sending them to me here or on Discord? macOS icons should be 1024x1024 and favicon.png is only 256x256.

Unfortunately, I do not :(

Yudi marked this pull request as ready for review

May 6, 2025 13:12

Works on latest macOS.

There’s some additional work that could be done, like adding menu controls and the icon resolution issue. I’ll look into those in separate PRs when I find some time.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, that's very useful effort. I added some comments/questions.

@Yudi did you close this by accident?

I checked the wrong folder for permissions, I'm fixing and testing it
Sorry lol

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This was referenced

May 10, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels

2 participants