Fix typos in wp_admin_notice() calls by dlh01 · Pull Request #5633 · WordPress/wordpress-develop (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

WordPress / wordpress-develop Public

Additional navigation options

Closed

dlh01 wants to merge 1 commit intoWordPress:trunkfrom

dlh01:fix/trac-59830/admin-notice

ConversationCommits (1)ChecksFiles changed

Closed

Fix typos in wp_admin_notice() calls#5633

dlh01 wants to merge 1 commit intoWordPress:trunkfrom

dlh01:fix/trac-59830/admin-notice

Conversation

@dlh01

Copy link

@dlh01 dlh01 commented

Nov 8, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/59830

@dlh01

[Fix typos in wp_admin_notice() calls](/WordPress/wordpress-develop/pull/5633/commits/0d8c7d8652cfc2d7377ed8d19f2b9562a55d7479 "Fix typos in `wp_admin_notice()` calls")

[0d8c7d8](/WordPress/wordpress-develop/pull/5633/commits/0d8c7d8652cfc2d7377ed8d19f2b9562a55d7479)

mukeshpanchal27

mukeshpanchal27 approved these changes Nov 8, 2023

View reviewed changes

Copy link

Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@mukeshpanchal27

Copy link

Member

mukeshpanchal27 commented

Nov 8, 2023

Patch working fine:
Screenshot 2023-11-08 at 12 14 21 PM

@qasumitbagthariya

Copy link

qasumitbagthariya commented

Nov 8, 2023

Patch is working as expected.

Before:
Before

After:
image

@SergeyBiryukov

Copy link

Member

SergeyBiryukov commented

Nov 8, 2023

Thanks for the PR! Merged in r57084.

@SergeyBiryukov SergeyBiryukov closed this

Nov 8, 2023

@dlh01 dlh01 deleted the fix/trac-59830/admin-notice branch

September 9, 2024 17:01

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dlh01 @mukeshpanchal27 @qasumitbagthariya @SergeyBiryukov