[C++,C#] respect the package override option for codecs and DTOs by nbradac · Pull Request #1024 · aeron-io/simple-binary-encoding (original) (raw)

@nbradac

@nbradac

@nbradac nbradac changed the title[C++] respect the package override option for C++ codecs and DTOs [C++,C#] respect the package override option for codecs and DTOs

Nov 13, 2024

@nbradac

@nbradac nbradac marked this pull request as ready for review

November 14, 2024 17:20

@ZachBray

Co-authored-by: Nate Bradac nate.bradac@weareadaptive.com

We've updated the C# generation tasks to include a schema that uses explicit package names on types blocks.

We found processing this schema produces some build errors (albeit not affecting the exit code):

> Task :generateCSharpTestCodecs
[Error] explicit-package-test-schema.xml:17:49: cvc-complex-type.3.2.2: Attribute 'package' is not allowed to appear in element 'types'.
[Error] explicit-package-test-schema.xml:30:37: cvc-complex-type.3.2.2: Attribute 'package' is not allowed to appear in element 'types'.

> Task :generateCSharpTestDtos
[Error] explicit-package-test-schema.xml:17:49: cvc-complex-type.3.2.2: Attribute 'package' is not allowed to appear in element 'types'.
[Error] explicit-package-test-schema.xml:30:37: cvc-complex-type.3.2.2: Attribute 'package' is not allowed to appear in element 'types'.

Therefore, we've put the new generation under tasks that don't validate against an XSD. We considered creating a new version of the XSD that properly describes what we support; however, the licence on the XSD seems prohibitive.

@nbradac nbradac deleted the cpp-and-csharp-package-overrides branch

November 15, 2024 18:58