dotnet core support by markmcdowell · Pull Request #456 · aeron-io/simple-binary-encoding (original) (raw)

The patch addresses something on the roadmap and I'd love to see it integrated. There are a bunch of improvements here.

I tried the following:
git clone git@github.com:real-logic/simple-binary-encoding.git
cd simple-binary-encoding
git fetch origin pull/456/head:dn
git checkout dn
gradlew
gradlew generatecsharpcodecs
cd csharp
csharpbuild.cmd

The build then proceeds until I see:
error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\MSTest.TestAdapter.1.1.17\build\net45\MSTest.TestAdapter.props

Once I've opened the solution and built from there then csharpbuild.cmd works.

I think we can accept the PR and look to fix the build script from clean checkout separately.

Bill.