✨ [Amp story] Activate desktop one panel experiment to 1. by processprocess · Pull Request #35453 · ampproject/amphtml (original) (raw)

Activates amp-story-desktop-one-panel to 1.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update client-side-experiments-config.json too? That's the one to use if you want the experiment to be instantly flipped

Do you want to immediately set it to 1 in prod/canary config, or gradually ramp it up through the client side experiments?

Do you want to immediately set it to 1 in prod/canary config, or gradually ramp it up through the client side experiments?

We don't have metrics to observe before deciding to launch, so we're thinking to push it all the way to 1.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but let's get formal wg-stories PM/UX approval before merging

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for client-side-experiments-config.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it!! 🚢

This PR has been picked up by the CDN and will begin deploying shortly

This experiment is now live and being served by the CDN

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})