🐛 [Story loading] Send storyContentLoaded during prerendering by mszylkowski · Pull Request #36307 · ampproject/amphtml (original) (raw)

[Not wait for storyLayoutPromise](/ampproject/amphtml/pull/36307/commits/b1936518abae89a041be1a7f938bba9bb793fd07 "Not wait for storyLayoutPromise")

[b193651](/ampproject/amphtml/pull/36307/commits/b1936518abae89a041be1a7f938bba9bb793fd07)

[Resolve medialayout on prerender](/ampproject/amphtml/pull/36307/commits/f802104d8aa11ac2480865c2aa67f1469498e176 "Resolve medialayout on prerender")

[f802104](/ampproject/amphtml/pull/36307/commits/f802104d8aa11ac2480865c2aa67f1469498e176)

mszylkowski commented Oct 11, 2021

View reviewed changes

extensions/amp-story/1.0/amp-story-page.js Outdated Show resolved Hide resolved

mszylkowski added 2 commits

October 11, 2021 13:14

[Use innerMedia readystate](/ampproject/amphtml/pull/36307/commits/11f6508827971cb365f0f6df97647c278100f4b1 "Use innerMedia readystate")

[11f6508](/ampproject/amphtml/pull/36307/commits/11f6508827971cb365f0f6df97647c278100f4b1)

[Remove unused import](/ampproject/amphtml/pull/36307/commits/a256a91414d87d4ead4fda6c2a2944fefe2a5f3d "Remove unused import")

[a256a91](/ampproject/amphtml/pull/36307/commits/a256a91414d87d4ead4fda6c2a2944fefe2a5f3d)

mszylkowski marked this pull request as ready for review

October 11, 2021 18:10

Copy link

amp-owners-bot bot commented

Oct 11, 2021

•

edited

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story.js

[Fixed tests](/ampproject/amphtml/pull/36307/commits/6e7b69399fbe644aa791165106a178e4af94d4c3 "Fixed tests")

[6e7b693](/ampproject/amphtml/pull/36307/commits/6e7b69399fbe644aa791165106a178e4af94d4c3)

gmajoulet approved these changes Oct 11, 2021

View reviewed changes

extensions/amp-story/1.0/amp-story-page.js Outdated Show resolved Hide resolved

[Check innerMediaEl exists](/ampproject/amphtml/pull/36307/commits/a7ebfbd440e2897c0b1320ed011e48b5735856c2 "Check innerMediaEl exists")

[a7ebfbd](/ampproject/amphtml/pull/36307/commits/a7ebfbd440e2897c0b1320ed011e48b5735856c2)

mszylkowskienabled auto-merge (squash)

October 11, 2021 20:19

mszylkowskidisabled auto-merge

October 11, 2021 20:26

mszylkowski added 10 commits

October 11, 2021 16:50

[Merge branch 'main' of github.com:ampproject/amphtml into initializep…](/ampproject/amphtml/pull/36307/commits/1f14ce0ada4ef8f29211817163aac5238177cf46 "Merge branch 'main' of github.com:ampproject/amphtml into initializepages_loadevent")

[1f14ce0](/ampproject/amphtml/pull/36307/commits/1f14ce0ada4ef8f29211817163aac5238177cf46)

…ages_loadevent

[Dialog visible](/ampproject/amphtml/pull/36307/commits/ad4c1b1e9bcea95bf7473342e7db67a1d384fefa "Dialog visible")

[ad4c1b1](/ampproject/amphtml/pull/36307/commits/ad4c1b1e9bcea95bf7473342e7db67a1d384fefa)

[Revert visual tests](/ampproject/amphtml/pull/36307/commits/9465318013a5a0d1d6164eb4372a8eeaf0bdd925 "Revert visual tests")

[9465318](/ampproject/amphtml/pull/36307/commits/9465318013a5a0d1d6164eb4372a8eeaf0bdd925)

[Merge branch 'main' of github.com:ampproject/amphtml into initializep…](/ampproject/amphtml/pull/36307/commits/f7a5e1767b02fe4fdf06bf59bd4fad9ea4997597 "Merge branch 'main' of github.com:ampproject/amphtml into initializepages_loadevent")

[f7a5e17](/ampproject/amphtml/pull/36307/commits/f7a5e1767b02fe4fdf06bf59bd4fad9ea4997597)

…ages_loadevent

[Added timer for vis test info dialog](/ampproject/amphtml/pull/36307/commits/126198fe9dfdb3353fd939dc2c81293328918d91 "Added timer for vis test info dialog")

[126198f](/ampproject/amphtml/pull/36307/commits/126198fe9dfdb3353fd939dc2c81293328918d91)

[Merge branch 'main' of github.com:ampproject/amphtml into initializep…](/ampproject/amphtml/pull/36307/commits/2ee4d88f0301ade62c4e70dc885fb127cf3ddfc9 "Merge branch 'main' of github.com:ampproject/amphtml into initializepages_loadevent")

[2ee4d88](/ampproject/amphtml/pull/36307/commits/2ee4d88f0301ade62c4e70dc885fb127cf3ddfc9)

…ages_loadevent

[Added timer to visual test](/ampproject/amphtml/pull/36307/commits/553cf8b7eb8b0e23995f8d51243ac12af61571d3 "Added timer to visual test")

[553cf8b](/ampproject/amphtml/pull/36307/commits/553cf8b7eb8b0e23995f8d51243ac12af61571d3)

[Merge branch 'main' of github.com:ampproject/amphtml into initializep…](/ampproject/amphtml/pull/36307/commits/313d914576c3eec95c24c716b77f2878c5f852cf "Merge branch 'main' of github.com:ampproject/amphtml into initializepages_loadevent")

[313d914](/ampproject/amphtml/pull/36307/commits/313d914576c3eec95c24c716b77f2878c5f852cf)

…ages_loadevent

[Merge branch 'main' of github.com:ampproject/amphtml into initializep…](/ampproject/amphtml/pull/36307/commits/9811a471679fc182f9ba27fded5218de9e2db33f "Merge branch 'main' of github.com:ampproject/amphtml into initializepages_loadevent")

[9811a47](/ampproject/amphtml/pull/36307/commits/9811a471679fc182f9ba27fded5218de9e2db33f)

…ages_loadevent

[Remove delay from visual tests](/ampproject/amphtml/pull/36307/commits/fff0ffb3282d9dd85a560725d5396d371a27860b "Remove delay from visual tests")

[fff0ffb](/ampproject/amphtml/pull/36307/commits/fff0ffb3282d9dd85a560725d5396d371a27860b)

mszylkowski merged commit 73201d9 into ampproject:main

Oct 14, 2021

mszylkowski deleted the initializepages_loadevent branch

October 14, 2021 20:10

processprocess mentioned this pull request

Oct 25, 2021

wg-stories Status Update 2021-10-22ampproject/wg-stories#85

Open

mszylkowski mentioned this pull request

Oct 26, 2021

[Story] storyContentLoaded event doesn't fire when loading story on page index != 0#36571

Closed

ampprojectbot added the PR use: In Stable label

Oct 27, 2021

ampprojectbot added the PR use: In LTS label

Nov 8, 2021

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})