✨ [amp story captions] get and set captions state from viewer by processprocess · Pull Request #38009 · ampproject/amphtml (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub SparkBuild and deploy intelligent apps
    * GitHub ModelsManage and compare prompts
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners
• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

ampproject / amphtml Public

• Notifications You must be signed in to change notification settings

• Fork4.1k

• Star 14.9k

• Code

• Issues 941

• Pull requests 69

• Actions

• Projects

• Security

• Insights

Additional navigation options

Merged

processprocess merged 3 commits intoampproject:mainfrom

processprocess:captions-messaging

Apr 18, 2022

ConversationCommits (3)ChecksFiles changed

Merged

✨ [amp story captions] get and set captions state from viewer#38009

processprocess merged 3 commits intoampproject:mainfrom

processprocess:captions-messaging

Conversation

Copy link

Contributor

processprocess commented

Apr 4, 2022

•

edited

Loading

Functionality and tests to get and set captions state from viewer.

Closes #37898

[captions stat get and set in viewer.](/ampproject/amphtml/pull/38009/commits/c3524685e994af3777c9156942c51a7964489bb8 "captions stat get and set in viewer.")

[c352468](/ampproject/amphtml/pull/38009/commits/c3524685e994af3777c9156942c51a7964489bb8)

processprocess changed the title✨ [amp story player] get and set captions state from viewer ✨ [amp story captions] get and set captions state from viewer

Apr 4, 2022

[Merge branch 'main' into captions-messaging](/ampproject/amphtml/pull/38009/commits/df314c434c2c3fe0901ff41750ce00dd1e723f5e "Merge branch 'main' into captions-messaging")

[df314c4](/ampproject/amphtml/pull/38009/commits/df314c434c2c3fe0901ff41750ce00dd1e723f5e)

processprocess requested review fromgmajoulet and mszylkowski

April 18, 2022 14:57

processprocess marked this pull request as ready for review

April 18, 2022 14:57

Copy link

amp-owners-bot bot commented

Apr 18, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-viewer-messaging-handler.js
extensions/amp-story/1.0/test/test-amp-story-viewer-messaging-handler.js

mszylkowski approved these changes Apr 18, 2022

View reviewed changes

gmajoulet approved these changes Apr 18, 2022

View reviewed changes

Copy link

Contributor

gmajoulet commented

Apr 18, 2022

Bundle-size shows +1kB, can you rebase your PR and make sure everything is ok?

[Merge branch 'ampproject:main' into captions-messaging](/ampproject/amphtml/pull/38009/commits/3c90ec71dfb874604045f87f5e56dadf71ad3a6a "Merge branch 'ampproject:main' into captions-messaging")

[3c90ec7](/ampproject/amphtml/pull/38009/commits/3c90ec71dfb874604045f87f5e56dadf71ad3a6a)

processprocess merged commit 60e73dd into ampproject:main

Apr 18, 2022

processprocess deleted the captions-messaging branch

April 18, 2022 21:00

ampprojectbot added PR use: In Beta / Experimental PR use: In Stable labels

Apr 27, 2022

jshamble mentioned this pull request

May 20, 2022

wg-stories Status Update 2022-05-20ampproject/wg-stories#103

Open

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

gmajoulet gmajoulet approved these changes

mszylkowski mszylkowski approved these changes

Assignees

No one assigned

Labels

PR use: In Beta / Experimental PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Amp story captions] Allow Players to get/set the captions state

4 participants