remove specific IDE m2e files by olamy · Pull Request #192 · apache/maven-enforcer (original) (raw)

those files are specific to m2e they shouldn;t be stored in the Apache Maven sources!

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

those files are specific to m2e they shouldn;t be stored in the Apache Maven sources!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olamy deleted the remove-m2e-files branch

December 15, 2022 00:43

Hello @olamy

I think this is a regression for all users of Eclipse and maven-enforcer-plugin. We now have a warning in all our pom files because of this change:

It means this change forces all those projects to each find a way to ignore this warning. And for now I have not found a way to do it on my side.

The goal of this META-INF/m2e/lifecycle-mapping-metadata.xml file is just to declare whether it makes sense to run this plugin in Eclipse or not, so that not all projects have to declare it on their side.

Would you consider reverting this change to help all those projects? Especially given there was no maintenance on this file for 8 years in this project, so not really costing this project anything.

Thanks a lot

Hi @kwin

looks like the ignore in the file you linked to has a different behavior than what we had with the META-INF/m2e/lifecycle-mapping-metadata.xml hosted in maven-enforcer-plugin itself. Before this file was removed, there would be no warning at all in Eclipse, and enforcer would not run as part of the Eclipse build.

Now enforcer still don't run, but we have this warning.

I asked about this in m2e too: eclipse-m2e/m2e-core#1229
But I think the easiest way forward is to add this file again.

Thanks

Sorry for the disagreement but this file should have never been added..
But your problem should be solved by m2e plugin.
Imagine if every single IDE asks to host their configuration file.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})