[MENFORCER-488] Add EnforcerLogger.isEnabled() by kwin · Pull Request #279 · apache/maven-enforcer (original) (raw)

@kwin

@kwin

slachiewicz

slawekjaranowski

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for completion we can add is...Enabled for other levels

@kwin

slawekjaranowski

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one missing isWarnOrErrorEnabled

@kwin

one missing isWarnOrErrorEnabled

I would prefer to leave that out, as the semantics is not clear from the name. It could mean both

  1. isWarnEnabled() || isErrorEnabled() or
  2. isWarnEnabled() && rule.getLevel() == EnforcerLevel.WARN || isErrorEnabled() && rule.getLevel() == EnforcerLevel.ERROR

Although one could clarify that in the javadoc the chance for misinterpretation is quite high and I would not add it until we see a real use case.

slawekjaranowski

@slawekjaranowski slawekjaranowski changed the title[MENFORCER-488] Add EnforcerLogger.isDebugEnabled() [MENFORCER-488] Add EnforcerLogger.isEnabled()

Jul 20, 2023

@jira-importer

1 similar comment

@jira-importer

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})