Introduce service executors for CPD, PMD executors by slawekjaranowski · Pull Request #206 · apache/maven-pmd-plugin (original) (raw)
Standard mojos and reports have different parent classes, so we need to extract tasks which both will execute.
We cannot use one abstract for both.
Standard mojos and reports have different parent classes, so we need to extract tasks which both will execute.
We cannot use one abstract for both.
Introduce service executors for Cpd, Pdm executors Introduce service executors for CPD, PMD executors
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wonder, whether we could merge CpdExecutor + CpdServiceExecutor and PmdExecutor + PmdServiceExecutor and Executor + ServiceExecutor. Having both an "executor" and a "service executor" sounds unnecessary to me...
Co-authored-by: Andreas Dangel andreas.dangel@adangel.org
LGTM.
I wonder, whether we could merge CpdExecutor + CpdServiceExecutor and PmdExecutor + PmdServiceExecutor and Executor + ServiceExecutor. Having both an "executor" and a "service executor" sounds unnecessary to me...
CpdExecutor/PmdExecutor are use in fokr mode with main static method .... but ServiceExecutor I use a constructor for inject needed components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})