Check all project parents for SCM information. by slawekjaranowski · Pull Request #1421 · apache/maven-release (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@slawekjaranowski

During the project transformation, we need to verify all parent projects.
Otherwise, modules at deeper levels may have an SCM tag added unnecessarily.

fix #1420

@slawekjaranowski

kwin

kwin approved these changes Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. Just minor remarks on comments. Otherwise LGTM

@slawekjaranowski

During the project transformation, we need to verify all parent projects. Otherwise, modules at deeper levels may have an SCM tag added unnecessarily.

fix apache#1420

@github-actions

@slawekjaranowski Please assign appropriate label to PR according to the type of change.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels

bug

Something isn't working

2 participants

@slawekjaranowski @kwin