use more modern I/O that does not rely on the system encoding by elharo · Pull Request #174 · apache/maven-release (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Merged
merged 1 commit into
Mar 16, 2023
Conversation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, is there any logical difference?
Yes, there is. The current code gets in trouble if pom.xml encoding is incompatible with the system encoding. E.g. one is UTF-16 and one is UTF-8, or one is ISO-8859-1 and one is ISO-8859-1 when non-ASCII characters are used. The new code lets the XML parser detect the encoding so it will determine how the pom.xml is actually encoded instead of assuming it's the same as the system encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
