[MRELEASE-851]: javaHome argument is now honored in InvokerMavenExecutor by prof-schnitzel · Pull Request #182 · apache/maven-release (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight problem with this PR, this it is correct, it is also incomplete. the actual issue says: "javaHome is ignored and inherited unexpected". So this should apply to both invoker (InvokerMavenExecutor) and forked-path (ForkedMavenExecutor).

For the ForkedMavenExecutor the JAVA_HOME env var isn't set.

Please make it consistent.

WDYT?