[MNG-6380] Option -Dstyle.color=always doesn't force color output by gnodet · Pull Request #67 · apache/maven-shared-utils (original) (raw)

I need to release jansi before merging this PR.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set env variables also?

I will have a look at this combined with other Maven issues in a few days.

I've pushed commits to leverage today's changes to Jansi.

@slachiewicz I'm not sure to understand your question, could you rephrase please ?

gnodet changed the title[MNG-6380] Update the wrapped jansi streams [MNG-6380] Option -Dstyle.color=always doesn't force color output

Jan 21, 2021

I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set env variables also?

The native libraries location have changed a bit with Jansi 2.x, so we need to properly change the maven distribution, see apache/maven@151e349

Running through jenkins on branch gnodet

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JAnsi looks released. Can this be merged?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 2.3.1 now?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but the 2.3.0/2.3.1 only brings two additional native methods specifically for mvnd and no other changes, so there is no real benefit either.

@gnodet I see that jansi was already upgraded in #69. Is this work still needed? Is it required or nice to have for the Maven Core 4.0.0 (alpha) release eventually?

@MartinKanters jansi is a dependency both maven-shared and core maven, so it needs to be upgraded in both. In addition, MNG-6380 is resolved with the commits in this PR and not simply the upgrade of jansi.

…uences are stripped or let through

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})