(doc) Throw more descriptive NPEx by pzygielo · Pull Request #95 · apache/maven-shared-utils (original) (raw)

Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

As suggested in MJAR-286:

If this is a misconfigured pom, it should at least give a proper error message.

Thus replacing JVM-thrown NPEx with the one with message.

pzygielo marked this pull request as ready for review

March 4, 2022 11:35

This comment was marked as outdated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple unit test will be appreciated 😉
it is public method

This verifies/locks current behavior of throwing NPEx on null being dereferenced in DirectoryScanner.setIncludes/Excludes.

pzygielo marked this pull request as ready for review

March 11, 2022 12:42

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})