[MWAR-453] Require Java 8 by slachiewicz · Pull Request #23 · apache/maven-war-plugin (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some open questions, but changes requested mainly due to merge commit.
| // Ok now check that there is no more files/directories |
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); |
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not a Java 8 change.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be reverted
| // Ok now check that there is no more files/directories |
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); |
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not a Java 8 change.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
| // Ok now check that there is no more files/directories |
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); |
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not a Java 8 change.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes