Simplify prefix resolution by cstamas · Pull Request #11072 · apache/maven (original) (raw)
First proposal, that is nearly trivial, just collect plugin groupIDs to check in proper order.
There may be tricks for plugins lacking G metadata...
cstamas added a commit to cstamas/maven that referenced this pull request
Simplify prefix resolution and drop use of BuildPluginManager (as descriptor will be re-resolved again later) and focus only on prefix to GA resolution, using a map of rules:
- collect POM enlisted plugin groupId:artifactId pairs that come from non-settings-enlisted groupIDs (and allow only enlisted artifactIDs)
- add settings enlisted plugin groupIds (keep their order) but "allow any" artifactId
Using this map, figure out plugin GA from prefix using Maven metadata only.
Fixes apache#11067
Backport of 2b7bb9c
cstamas added a commit that referenced this pull request
Simplify prefix resolution and drop use of BuildPluginManager (as descriptor will be re-resolved again later) and focus only on prefix to GA resolution, using a map of rules:
- collect POM enlisted plugin groupId:artifactId pairs that come from non-settings-enlisted groupIDs (and allow only enlisted artifactIDs)
- add settings enlisted plugin groupIds (keep their order) but "allow any" artifactId
Using this map, figure out plugin GA from prefix using Maven metadata only.
Fixes #11067
Backport of 2b7bb9c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})