Fix exception caused by duplicate dependencies in consumer pom by gnodet · Pull Request #11283 · apache/maven (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perso I prefer isBlank() since 11+

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure though... All the checks are done with isEmpty() in the code, so introducing a isBlank() at one point may lead to inconsistencies.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I agree, I just said "my 5 cents"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it was probably me ... 😆