Add MultiProducerSingleConsumerChannel by FranzBusch · Pull Request #305 · apple/swift-async-algorithms (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all I think this is a lot of complicated machinery, it is definitely filling a gap of use; but we need to be careful about how widely this is expected to be used; the long name right now is definitely keeping that progressive disclosure correct, but I think we can soften some of the requirements a bit and find a better name; right now it is pretty wordy.

All that being said; id say that since the need (and conjunction with other efforts makes it reasonable) then it is worth running this to get some additional feedback by focusing the review on how we can make some of the uses a bit more straightforward and suggestions on what the appropriate name is.