settings: add network.connection_timeout and `network.cloud_api.ski… · arduino/arduino-cli@5968346 (original) (raw)

`@@ -224,12 +224,73 @@ func TestDelete(t *testing.T) {

`

224

224

`srv := NewArduinoCoreServer()

`

225

225

`loadConfig(t, srv, paths.New("testdata", "arduino-cli.yml"))

`

226

226

``

227

``

`-

_, err := srv.SettingsGetValue(context.Background(), &rpc.SettingsGetValueRequest{Key: "network"})

`

``

227

`+

// Check loaded config

`

``

228

`+

resp, err := srv.ConfigurationSave(context.Background(), &rpc.ConfigurationSaveRequest{

`

``

229

`+

SettingsFormat: "yaml",

`

``

230

`+

})

`

``

231

`+

require.NoError(t, err)

`

``

232

`` +

require.YAMLEq(t, `

``

``

233

`+

board_manager:

`

``

234

`+

additional_urls:

`

``

235

`+

`

``

236

`+

`

``

237

+

``

238

`+

daemon:

`

``

239

`+

port: "50051"

`

``

240

+

``

241

`+

directories:

`

``

242

`+

data: /home/massi/.arduino15

`

``

243

`+

downloads: /home/massi/.arduino15/staging

`

``

244

+

``

245

`+

logging:

`

``

246

`+

file: ""

`

``

247

`+

format: text

`

``

248

`+

level: info

`

``

249

+

``

250

`+

network:

`

``

251

`+

proxy: "123"

`

``

252

`` +

`, resp.GetEncodedSettings())

``

``

253

+

``

254

`+

// Check default and setted values

`

``

255

`+

res, err := srv.SettingsGetValue(context.Background(), &rpc.SettingsGetValueRequest{Key: "network"})

`

``

256

`+

require.NoError(t, err)

`

``

257

`` +

require.Equal(t, {"proxy":"123"}, res.GetEncodedValue())

``

``

258

`+

// Maybe should be like this?

`

``

259

`` +

// require.Equal(t, {"proxy":"123","connection_timeout":"1m0s"}, res.GetEncodedValue())

``

``

260

`+

res, err = srv.SettingsGetValue(context.Background(), &rpc.SettingsGetValueRequest{Key: "network.connection_timeout"})

`

``

261

`` +

require.Equal(t, "1m0s", res.GetEncodedValue()) // default value

``

228

262

`require.NoError(t, err)

`

229

263

``

``

264

`+

// Run deletion

`

230

265

`_, err = srv.SettingsSetValue(context.Background(), &rpc.SettingsSetValueRequest{Key: "network", EncodedValue: ""})

`

231

266

`require.NoError(t, err)

`

``

267

`+

resp, err = srv.ConfigurationSave(context.Background(), &rpc.ConfigurationSaveRequest{

`

``

268

`+

SettingsFormat: "yaml",

`

``

269

`+

})

`

``

270

`+

require.NoError(t, err)

`

``

271

`` +

require.YAMLEq(t, `

``

``

272

`+

board_manager:

`

``

273

`+

additional_urls:

`

``

274

`+

`

``

275

`+

`

232

276

``

233

``

`-

_, err = srv.SettingsGetValue(context.Background(), &rpc.SettingsGetValueRequest{Key: "network"})

`

234

``

`-

require.Error(t, err)

`

``

277

`+

daemon:

`

``

278

`+

port: "50051"

`

``

279

+

``

280

`+

directories:

`

``

281

`+

data: /home/massi/.arduino15

`

``

282

`+

downloads: /home/massi/.arduino15/staging

`

``

283

+

``

284

`+

logging:

`

``

285

`+

file: ""

`

``

286

`+

format: text

`

``

287

`+

level: info

`

``

288

`` +

`, resp.GetEncodedSettings())

``

``

289

`+

// Check default and setted values

`

``

290

`+

res, err = srv.SettingsGetValue(context.Background(), &rpc.SettingsGetValueRequest{Key: "network"})

`

``

291

`+

require.NoError(t, err)

`

``

292

`` +

require.Equal(t, {"connection_timeout":"1m0s"}, res.GetEncodedValue())

``

``

293

`+

res, err = srv.SettingsGetValue(context.Background(), &rpc.SettingsGetValueRequest{Key: "network.connection_timeout"})

`

``

294

`` +

require.Equal(t, "1m0s", res.GetEncodedValue()) // default value

``

``

295

`+

require.NoError(t, err)

`

235

296

`}

`