Revert "Improved lib detection: check for matching name in library.properties (#1276)" by silvanocerza · Pull Request #1290 · arduino/arduino-cli (original) (raw)
Please check if the PR fulfills these requirements
- The PR has no duplicates (please search among the Pull Requests
before creating one) - The PR follows
our contributing guidelines - Tests for the changes have been added (for bug fixes / features)
- Docs have been added / updated (for bug fixes / features)
UPGRADING.mdhas been updated with a migration guide (for breaking changes)- What kind of change does this PR introduce?
Reverts a fix that is causing unforeseen consequences.
- What is the current behavior?
Sketch compilation is broken for ESP32 boards when using a library that is installed both in the Sketchbook folder and the core folder.
The reverted commit changed the way libraries are resolved so that the name set in the library.properties is checked to understand which library to included; the libraries included in the ESP32 core have a different name in library.properties because of legacy reasons from the Java IDE.
Compiling a Sketch that includes OneWire.h with both OneWire and OneWireng libraries installed compiles correctly.
- What is the new behavior?
Sketch compilation is not broken anymore for ESP32 boards when using a library that is installed both in the Sketchbook folder and the core folder.
Compiling a Sketch that includes OneWire.h with both OneWire and OneWireng libraries installed doesn't compile anymore.
- Does this PR introduce a breaking change, and is
titled accordingly?
No.
- Other information:
This reverts commit 15e81eddb96abfe99fe094db9a433965ea3c7ad7 from PR #1276.