Made the golang 'version' package internal by cmaglie · Pull Request #2767 · arduino/arduino-cli (original) (raw)

Please check if the PR fulfills these requirements

See how to contribute

• The PR has no duplicates (please search among the Pull Requests
  before creating one)
• The PR follows
  our contributing guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• UPGRADING.md has been updated with a migration guide (for breaking changes)
• configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

It makes the version package internal.

What is the current behavior?

The package version is publicly importable.

What is the new behavior?

The package version is private.

Does this PR introduce a breaking change, and is titled accordingly?

Strictly speaking, yes. By the way, this is a purely theoretical breaking change because the version package is useless outside the Arduino CLI, and there is no point in exporting it. I'll consider this patch more of a bug fix than a breaking change.

Other information