settings: add network.connection_timeout and network.cloud_api.skip_board_detection_calls by alessio-perugini · Pull Request #2770 · arduino/arduino-cli (original) (raw)
Please check if the PR fulfills these requirements
- The PR has no duplicates (please search among the Pull Requests
before creating one) - The PR follows
our contributing guidelines - Tests for the changes have been added (for bug fixes / features)
- Docs have been added / updated (for bug fixes / features)
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.
What kind of change does this PR introduce?
Introduces:
- the
connection_timeoutsetting, which our HTTP client will use as a timeout duration - the
cloud_api.skip_board_detection_callsboolean setting that (iftrue) will skip the API call required to identify the board (if no installed platforms match the board).
What is the current behavior?
The current behavior uses the default timeout which is 0. It means that it will wait indefinitely.
What is the new behavior?
The new behavior will respect user settings for the connection timeout. The default will be the same, but in case the user provides the network.connection_timeout: 5 it means that the HTTP client will exit with an error if the connection is taking longer than 5 seconds.
There is also a new configuration value to disable querying the Cloud API to identify a board.