Do not use crossbuild container when CGO=0 by alessio-perugini · Pull Request #2943 · arduino/arduino-cli (original) (raw)
Please check if the PR fulfills these requirements
- The PR has no duplicates (please search among the Pull Requests
before creating one) - The PR follows
our contributing guidelines - Tests for the changes have been added (for bug fixes / features)
- Docs have been added / updated (for bug fixes / features)
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.
What kind of change does this PR introduce?
Golang supports cross-building by default. With this PR I propose not to use the crossbuild container of Elastic, when we are building without cgo. This will make our build process faster, and we minimize the dependency on Elastic Container at the bare minimum.
The trigger of this PR is that Elastic seem to have broke the manifest of arm images, and we are now blocked by bumping our go version.
What is the current behavior?
We are always using the elastic crossbuild container
What is the new behavior?
When building without CGO use native golang cross build capabilities