Allow leading underscore in sketch filenames by per1234 · Pull Request #510 · arduino/arduino-lint (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
per1234 merged 2 commits intoarduino:mainfromper1234:allow_sketch_leading_underscore
Mar 13, 2023
Conversation1 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino Lint's rule SS002 checks compliance with the specification.
The Arduino Sketch Specification is being changed to allow a leading underscore in sketch folder names and sketch code filenames:
The Arduino Lint rule code must be updated accordingly.
Previously the test data for the unit tests of this function did not provide full coverage of all valid sketch filename formats.
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino Lint's rule SS002 checks compliance with the specification.
The Arduino Sketch Specification has been changed to allow a leading underscore in sketch folder names and sketch code filenames so the Arduino Lint rule code must be updated accordingly.
Allow sketch leading underscore Allow leading underscore in sketch filenames
Codecov Report
Patch and project coverage have no change.
Comparison is base (059c3a0) 90.05% compared to head (fa2d53e) 90.05%.
Additional details and impacted files
@@ Coverage Diff @@ ## main #510 +/- ##
Coverage 90.05% 90.05%
Files 44 44
Lines 6800 6800
Hits 6124 6124
Misses 553 553
Partials 123 123
| Flag | Coverage Δ |
|---|---|
| unit | 90.05% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
