[ty] Fix server panic when calling system_mut by MichaReiser · Pull Request #18252 · astral-sh/ruff (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@MichaReiser

Summary

Drop order matters... See inline comment

Fixes astral-sh/ty#469

Test Plan

I added a fake sleep of 5s to the diagnostics handler. I then typed a ton and wasn't able to reproduce the error where I was before the fix.

@MichaReiser MichaReiser added bug

Something isn't working

server

Related to the LSP server

ty

Multi-file analysis & type inference

labels

May 22, 2025

@github-actions

mypy_primer results

No ecosystem changes detected ✅

@MichaReiser

sharkdp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff — thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels

bug

Something isn't working

server

Related to the LSP server

ty

Multi-file analysis & type inference

2 participants

@MichaReiser @sharkdp