[ty] Include setters and deleters when renaming properties by charliermarsh · Pull Request #22999 · astral-sh/ruff (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too bad, since in this case it actually breaks the code. Do we have an issue open to track correct handling of shadowed bindings?

If the logic is really "same name in same scope", then why don't we also rename the def my_func above, which defines the same name in the same scope?

(Sorry if I'm asking a bunch of questions that are sort of orthogonal to this PR and maybe you aren't the right person to answer 😆 )