feat: remove Python3.7 support by texastony · Pull Request #648 · aws/aws-encryption-sdk-python (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits8 Checks153 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Issue #, if available:

Description of changes:

Stop testing or advertising support for py3.7
Tell PyPi we support 3.10, 3.11, 3.12

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

texastony changed the title~~chore: remove py3.7 testing~~ feat: remove Python3.7 support

Mar 2, 2024

On Approval, we should remove Python3.7 from required Checks.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important.
Question: Can we also remove appveyor.yml as part of this change?

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important. Question: Can we also remove appveyor.yml as part of this change?

All these asks are reasonable.
I am not going to work on them right now, as I need to focus on my sprint work.
But the On Call or anyone can push to this branch to address these.

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important. Question: Can we also remove appveyor.yml as part of this change?

Already removed here: e28d146