"NoPrintConversion" functional option by Kjeldgaard · Pull Request #24 · barasher/go-exiftool (original) (raw)

Hi @Kjeldgaard, thanks for the PR !

This feature is bothering me:

• 👍 on one side, it enabled exiftool tuning to fit the user's need
• 👎 on the other side, it can completely break go-exiftool if exiftool behaviour changes too much
  For instance, if the provided parameters change the extracted metadata serialization in a way that go-exiftool does not support, the library will behave incorrectly

Exiftool supports so many parameters that it will be really hard to test and filter.

But since I consider that this feature might interest some users, let's do this this way:

• add some unit tests to your code
• tell clearly in the godoc comments that this feature is "dangerous" (unsafe) if not well mastered, that extra parameter might break the library and that most of the users should not use this feature
• add a paragraph Advanced usage in the README.MD and give a real example for this functional option